-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(DD_DEDUPLICATION_ALGORITHM_PER_PARSER + DD_HASHCODE_FIELDS_PER_SCANNER): Add checker of values #11244
Conversation
DryRun Security SummaryThe provided code changes focus on enhancing the security-related configurations and documentation of the DefectDojo application, particularly improving the deduplication and hashcode calculation mechanisms, and providing more detailed information about various features, such as tags, risk acceptance, deduplication, SLA management, reporting, and metrics. Expand for full summarySummary: The provided code changes focus on enhancing the security-related configurations and documentation of the DefectDojo application. The key changes include improvements to the deduplication and hashcode calculation mechanisms, which are crucial for effective vulnerability management. Additionally, the documentation updates provide more detailed information about various features, such as tags, risk acceptance, deduplication, SLA management, reporting, and metrics. From an application security perspective, the deduplication and hashcode calculation configurations are particularly noteworthy. The ability to configure different deduplication algorithms and hashcode computation settings per scanner/parser helps improve the accuracy and reliability of the deduplication process, which is essential for effectively managing security findings. The inclusion of security-related settings, such as CSRF, session, and content security configurations, also helps strengthen the overall security of the application. The documentation updates cover a wide range of features, providing users with a comprehensive understanding of the capabilities and security-related aspects of the DefectDojo application. This level of transparency and documentation is commendable, as it helps users make informed decisions and effectively utilize the security tools and features provided by the application. Files Changed:
Code AnalysisWe ran Riskiness🟢 Risk threshold not exceeded. |
7275641
to
48b7661
Compare
@kiblik thank you for improvment.
I understand it like I need to use something like:
but DD expects:
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
48b7661
to
133e2ef
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
133e2ef
to
46f08eb
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
46f08eb
to
f00c756
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
f00c756
to
8f7e4eb
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…CANNER): Add checker of values
8f7e4eb
to
a033ce8
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
This PR:
DD_DEDUPLICATION_ALGORITHM_PER_PARSER
to documentationDD_DEDUPLICATION_ALGORITHM_PER_PARSER
andDD_HASHCODE_FIELDS_PER_SCANNER
has the correct formatTested manually on following scenarios:
DD_DEDUPLICATION_ALGORITHM_PER_PARSER: '{"Trivy scan": "DEDUPE_ALGO_UNIQUE_ID_FROM_TOOL"}'
:AttributeError: DEDUP algorithm 'DEDUPE_ALGO_UNIQUE_ID_FROM_TOOL' for 'Trivy scan' is not valid. Use one of following values: legacy, unique_id_from_tool, hash_code, unique_id_from_tool_or_hash_code
DD_DEDUPLICATION_ALGORITHM_PER_PARSER: '{"Trivy scan": "unique_id_from_tool_or_hash_code"}'
DD_HASHCODE_FIELDS_PER_SCANNER: '{"Trivy scan": "cwe"}'
TypeError: Fields definition 'cwe' for hashcode calculation of 'Trivy scan' is not valid. It needs to be list of strings but it is <class 'str'>.
DD_HASHCODE_FIELDS_PER_SCANNER: '{"Trivy scan": [1]}'
AttributeError: Fields for hashcode calculation for Trivy scan are not valid. It needs to be list of strings. Some of fields are not string.
DD_HASHCODE_FIELDS_PER_SCANNER: '{"Trivy scan": ["cwe"]}'
Context: https://owasp.slack.com/archives/C2P5BA8MN/p1731339375410859